Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty link causing NullPointerException #693

Merged
merged 1 commit into from
Jan 24, 2017
Merged

fix empty link causing NullPointerException #693

merged 1 commit into from
Jan 24, 2017

Conversation

chonton
Copy link
Contributor

@chonton chonton commented Jan 20, 2017

When configuration has an empty link, a NullPointerException is thrown.

  <configuration>
    <links>
      <link></link>
    </links>
...
  </configuration>

@codecov-io
Copy link

Current coverage is 49.21% (diff: 100%)

Merging #693 into master will increase coverage by 0.03%

@@             master       #693   diff @@
==========================================
  Files           124        124          
  Lines          6357       6358     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       1080       1080          
==========================================
+ Hits           3126       3129     +3   
+ Misses         2961       2960     -1   
+ Partials        270        269     -1   
Diff Coverage File Path
•••••••••• 100% .../main/java/io/fabric8/maven/docker/util/EnvUtil.java

Sunburst

Powered by Codecov. Last update 6a707c6...0faafbb

@rhuss
Copy link
Collaborator

rhuss commented Jan 23, 2017

Thanks ! LGTM

@rhuss rhuss merged commit d4b624d into fabric8io:master Jan 24, 2017
rgbj pushed a commit to rgbj/docker-maven-plugin that referenced this pull request Jun 21, 2017
fix empty link causing NullPointerException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants